irmin-cli: change --store irf to --store fs #2243
Conversation
There was a problem hiding this comment.
This looks great. Backwards compatibility is fine to break for this usage, especially since it was wrong wrt the docs. 🙈
Can you also put an entry in CHANGES.md mentioning the fix? (just insert a new ## Unreleased section at the top and follow the pattern of previous entries)
Thanks!
no probs, just force pushed that too. Some context, I'm here on the mirageOS retreat and trying to learn more about Irmin so I thought I'd try some beginner bugs. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #2243 +/- ##
==========================================
- Coverage 67.93% 67.91% -0.02%
==========================================
Files 136 136
Lines 16603 16605 +2
==========================================
- Hits 11279 11278 -1
- Misses 5324 5327 +3
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
wyn
force-pushed
the
swp-2234-irmin-cli-change-irf-to-fs
branch
from
6114435 to
ff16de9
Compare
Awesome -- enjoy the retreat! 🐫 |
wyn
force-pushed
the
swp-2234-irmin-cli-change-irf-to-fs
branch
from
ff16de9 to
2670175
Compare
The information in the Irmin website uses "fs" where-as the irmin-cli Resolver uses "irf". Changed command line and module sig to use fs and also updated cram tests. NOTE previous use of "irf" will now error.
wyn
force-pushed
the
swp-2234-irmin-cli-change-irf-to-fs
branch
from
2670175 to
2e10154
Compare
|
Thanks! |
…min-pack, irmin-pack-tools, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.8.0)
CHANGES:
### Added
- **irmin**
- Change behavior of `Irmin.Conf.key` to disallow duplicate key names by
default. Add `allow_duplicate` optional argument to override. (mirage/irmin#2252,
@metanivek)
- **irmin-pack**
- Add maximum memory as an alternative configuration option, `lru_max_memory`,
for setting LRU capacity. (@metanivek, mirage/irmin#2254)
### Changed
- **irmin**
- Lower bound for `mtime` is now `2.0.0` (mirage/irmin#2166, @patricoferris)
- **irmin-mirage-git**
- Lower bound for `mirage-kv` is now `6.0.0` (mirage/irmin#2256, @metanivek)
### Fixed
- **irmin-cli**
- Changed `--store irf` to `--store fs` to align the CLI with what is
published on the Irmin website (mirage/irmin#2243, @wyn)
The information in the Irmin website uses "fs" where-as the irmin-cli Resolver uses "irf". Changed command line and module sig to use fs and also updated cram tests.
NOTE previous use of "irf" will now error, I wasn't sure whether backwards compatibility was expected?
As an example, looking at the cli
--helpsegment:before
after