Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lockfile for main #1774

Closed
wants to merge 6 commits into from
Closed

Add lockfile for main #1774

wants to merge 6 commits into from

Conversation

maiste
Copy link
Contributor

@maiste maiste commented Feb 15, 2022

This is a Proof-Of-Concept as it relies on a patch (thanks to @TheLortex) while waiting for this avsm/ocaml-yaml#41 to be merged.

With dune.3.0 and the PR included, we will be able to provide a viable opam monorepo lock file.

To test this PR:

$ git clone https://github.com/maiste/irmin.git
$ git checkout maiste@lockfile
$ opam switch create . --empty
$ eval $(opam env)
$ opam monorepo pull

@maiste maiste added area/integration Related to other repos (Repr, Index, etc) type/experiment Experimentation do-not-merge Do not merge this PR labels Feb 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1774 (ffbea06) into main (679343f) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head ffbea06 differs from pull request most recent head b3fca52. Consider uploading reports for the commit b3fca52 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1774   +/-   ##
=======================================
  Coverage   64.53%   64.54%           
=======================================
  Files         115      115           
  Lines       14057    14057           
=======================================
+ Hits         9072     9073    +1     
+ Misses       4985     4984    -1     
Impacted Files Coverage Δ
src/irmin-unix/fs.ml 67.74% <0.00%> (-0.65%) ⬇️
src/irmin-test/store.ml 95.10% <0.00%> (+0.05%) ⬆️
src/irmin/store.ml 64.67% <0.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 679343f...b3fca52. Read the comment docs.

@maiste maiste added the no-changelog-needed No changelog is needed here label Mar 3, 2022
@maiste maiste marked this pull request as ready for review March 4, 2022 09:56
@craigfe
Copy link
Member

craigfe commented Mar 4, 2022

@maiste: you may find that you need to add (vendored_dirs duniverse) to a top-level dune file to get the CI to pass, as otherwise I think the monorepo universe will be built and tested as if it were part of the Irmin source.

@maiste
Copy link
Contributor Author

maiste commented Mar 4, 2022

Thanks! Indeed, it would be bad if we test the entire duniverse we are importing....

@maiste
Copy link
Contributor Author

maiste commented Mar 9, 2022

After discussion, we are going to wait opam-monorepo overlays packages port to dune.3 before considering this PR.

@maiste maiste marked this pull request as draft March 9, 2022 15:27
@maiste
Copy link
Contributor Author

maiste commented Jun 17, 2022

As this lockfile is not up to date anymore this PR can be closed.

@maiste maiste closed this Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/integration Related to other repos (Repr, Index, etc) do-not-merge Do not merge this PR no-changelog-needed No changelog is needed here type/experiment Experimentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants