Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return / for parent / and basename / #25

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

yomimono
Copy link
Contributor

@yomimono yomimono commented Jan 5, 2022

List.hd and List.tl throw Invalid_argument on empty lists. Instead
of allowing this, define / as its own parent and basename.

`List.hd` and `List.tl` throw Invalid_argument on empty lists. Instead
of allowing this, define / as its own parent and basename.
@yomimono
Copy link
Contributor Author

I haven't kept track of fmt's API changes, but I think the CI failures are unrelated to this PR, as they all seem related to deprecated fmt functions.

Copy link
Contributor

@talex5 talex5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks obviously correct to me. The ocamldoc in the interface file even specifies these behaviours explicitly!

[basename empty] is the empty string [""]
[parent empty] is [empty]

@talex5 talex5 merged commit 9496437 into mirage:main Jan 17, 2022
@yomimono yomimono mentioned this pull request Feb 11, 2022
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Feb 28, 2022
CHANGES:

* Return `/` for `parent /` and `basename /` (@yomimono, @talex5, mirage/mirage-kv#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants