Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key.pp: escape the entire string, not individual segments #35

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Key.pp: escape the entire string, not individual segments #35

merged 1 commit into from
Oct 18, 2022

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Oct 13, 2022

No description provided.

reynir
reynir approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@reynir reynir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine to me. Is it correct that this doesn't change the output at all?

@hannesm
Copy link
Member Author

hannesm commented Oct 18, 2022

I think it changes from /"foo"/"bar" to "/foo/bar" -- since earlier (since #30) each segment was escaped individually, and last the / were added. Now, first the string is constructed and than at once escaped.

@hannesm hannesm merged commit c66cf9d into mirage:main Oct 18, 2022
@hannesm hannesm deleted the escape2 branch October 18, 2022 21:12
@reynir
Copy link
Member

reynir commented Oct 19, 2022

Ah yes indeed. This is much better. Thanks!

@hannesm hannesm mentioned this pull request Dec 12, 2022
Merged
hannesm added a commit to hannesm/opam-repository that referenced this pull request Dec 12, 2022
@hannesm
[new release] mirage-kv (6.0.0)
88a07b4 
CHANGES:

* Use ptime directly for RO.last_modified, instead of the int * int64 pair
  (mirage/mirage-kv#34)
* Add RW.allocate to allocate a key and fill it with zero bytes (mirage/mirage-kv#34)
* RO.list: return Key.t instead of string (mirage/mirage-kv#37, fixes mirage/mirage-kv#33)
* Introduce a custom error for RW.rename with a source which is a prefix of
  destination (mirage/mirage-kv#37, fixes mirage/mirage-kv#31)
* Use Optint.Int63.t for RO.size, RO.get_partial, RO.set_partial (mirage/mirage-kv#37, fixes mirage/mirage-kv#32)
* Remove RW.batch (mirage/mirage-kv#37, fixes mirage/mirage-kv#29 mirage/mirage-kv#36, discussed at the MirageOS meeting in
  November, and on the mirageos-devel mailing list in January 2022)
* Key.pp: escape the entire string, not individual fragments (mirage/mirage-kv#35)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reynir reynir reynir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hannesm @reynir