Remove all the `let _ =` in the tcp code #144

samoht · 2015-05-28T18:50:35Z

Ignoring an lwt thread is not a good idea, as usually you want to ensure some kind of sequentiality between side-effects.

The text was updated successfully, but these errors were encountered:

talex5 · 2015-05-28T18:58:09Z

Yes. And even if not, it should at least use Lwt.async so if it fails the error gets reported somewhere.

samoht added a commit to samoht/mirage-tcpip that referenced this issue Jun 1, 2015

Remove "let _" in Tcp code

4562f6a

Fix mirage#144

hannesm pushed a commit to hannesm/mirage-tcpip that referenced this issue Jun 5, 2015

Remove "let _" in Tcp code

e4893fb

Fix mirage#144

samoht added a commit to samoht/mirage-tcpip that referenced this issue Jun 6, 2015

Remove "let _" in Tcp code

bcd3194

Fix mirage#144

samoht added a commit to samoht/mirage-tcpip that referenced this issue Jun 8, 2015

Remove "let _" in Tcp code

e0cce8b

Fix mirage#144

samoht added a commit to samoht/mirage-tcpip that referenced this issue Jun 9, 2015

Remove "let _" in Tcp code

f7c2a05

Fix mirage#144

samoht added a commit to samoht/mirage-tcpip that referenced this issue Jun 10, 2015

Remove "let _" in Tcp code

ea914a4

Fix mirage#144

samoht closed this as completed in 7cecc9f Jun 10, 2015

samoht added a commit to samoht/mirage-tcpip that referenced this issue Apr 4, 2017

Remove "let _" in Tcp code

5298034

Fix mirage#144

Provide feedback