Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iperf and vnetif improvements #149

Merged
merged 2 commits into from
Jun 9, 2015
Merged

Conversation

MagnusS
Copy link
Member

@MagnusS MagnusS commented Jun 9, 2015

  • Remove unnecessary calls to sleep
  • Remove calls to flush when writing to pcap output channel
  • Catch pcap write errors

@MagnusS
Copy link
Member Author

MagnusS commented Jun 9, 2015

The listener function that writes to the pcap file is called with Lwt.async by the backend, resulting in a race when closing the pcap output channel. If packets are written to the channel while it is being closed this triggers a Channel_closed exception and the test fails. There is still a race with this patch, but the exception is caught. I have also removed the unnecessary call to Lwt_io.flush which should make it more likely that the recorder has completed before the channel is closed.

samoht added a commit that referenced this pull request Jun 9, 2015
Iperf and vnetif improvements
@samoht samoht merged commit ac7e93e into mirage:master Jun 9, 2015
@samoht samoht mentioned this pull request Jun 9, 2015
@samoht
Copy link
Member

samoht commented Jun 9, 2015

Thanks!

samoht added a commit to samoht/mirage-tcpip that referenced this pull request Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants