Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: explicit signature for async #799

Merged
merged 1 commit into from
Jan 3, 2022
Merged

refactor: explicit signature for async #799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cohttp-async/src/cohttp_async.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
module Body = Body
Copy link
Collaborator

@mseri mseri Jan 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik Body and Body_raw are essentially the same module. Is there a specific reason to keep them both? Should Body_raw at least be in a Private submodule?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just because I don't want to make any breaking changes in this PR. We can do deprecations or breakages separately.

module Body_raw = Body_raw
module Client = Client
module Io = Io
module Request = Request
module Response = Response
module Server = Server