Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sexplib dependency #222

Closed
hannesm opened this issue Feb 24, 2019 · 2 comments · Fixed by #239 or ocaml/opam-repository#13748
Closed

sexplib dependency #222

hannesm opened this issue Feb 24, 2019 · 2 comments · Fixed by #239 or ocaml/opam-repository#13748

Comments

@hannesm
Copy link
Member

hannesm commented Feb 24, 2019

can we make the sexplib dependency optional (similar to how it was done in uri and ipaddr)!? thanks //cc @avsm (this is first for the main cstruct package, but same would be nice for the ppx_cstruct package - see #116).
@avsm
Copy link
Member

avsm commented Feb 26, 2019

Yes, this is fine by me. will do in a separate major rev

@avsm
Copy link
Member

avsm commented Mar 19, 2019

@TheLortex also requests this for mirage/mirage#969 simplification

avsm added a commit to avsm/ocaml-cstruct that referenced this issue Mar 19, 2019
@avsm
Sexplib is now an optional library for the base Cstruct module.
5b9d1da 
A new `Cstruct_sexp` module has been introduced with the serialiser
functions, contained within the `cstruct-sexp` opam package.

To convert old code, simply use `Cstruct_sexp.t` instead of
`Cstruct.t` in a record type for which you are using `[@@deriving sexp]`.
This is a type alias to `Cstruct.t` but also has the right
sexp-conversion functions in scope.  There is an example of this
in the `ppx_test/with-sexp` directory in the source repo.

fixes mirage#222
avsm added a commit to avsm/ocaml-cstruct that referenced this issue Mar 19, 2019
@avsm
Sexplib is now an optional library for the base Cstruct module.
847f11f 
A new `Cstruct_sexp` module has been introduced with the serialiser
functions, contained within the `cstruct-sexp` opam package.

To convert old code, simply use `Cstruct_sexp.t` instead of
`Cstruct.t` in a record type for which you are using `[@@deriving sexp]`.
This is a type alias to `Cstruct.t` but also has the right
sexp-conversion functions in scope.  There is an example of this
in the `ppx_test/with-sexp` directory in the source repo.

fixes mirage#222
@avsm avsm mentioned this issue Mar 19, 2019
Merged
@avsm avsm closed this as completed in #239 Mar 20, 2019
avsm added a commit to avsm/opam-repository that referenced this issue Mar 25, 2019
@avsm
[new release] cstruct-async, ppx_cstruct, cstruct, cstruct-unix, cstr…
04f5a5b 
…uct-sexp and cstruct-lwt (4.0.0)

CHANGES:

- Sexplib is now an optional library for the base `Cstruct` module.
  A new `Cstruct_sexp` module has been introduced with the serialiser
  functions, contained within the `cstruct-sexp` opam package.

  To convert old code, simply use `Cstruct_sexp.t` instead of
  `Cstruct.t` in a record type for which you are using `[@@deriving sexp]`.
  This is a type alias to `Cstruct.t` but also has the right
  sexp-conversion functions in scope.  There is an example of this
  in the `ppx_test/with-sexp` directory in the source repo.

  When you have converted and released your library, add an
  opam constraint of `cstruct {>="4.0.0"}` to your own opam
  packages to ensure that they pick up this version of the library.
  (fixes mirage/ocaml-cstruct#222, @avsm)

- JavaScript stubs are now installed using the jsoo mechanism
  rather than a manual specification (mirage/ocaml-cstruct#241 @jonludlam)

- Use computed versions in opam files to ensure that dependent
  opam packages such as cstruct-async get the same base version
  of cstruct to avoid mismatches. (@avsm)

- Add a ppx test suite to checks that all error paths in ppx
  handling are reachable and have meaningful location info (mirage/ocaml-cstruct#238 @emillon)
@avsm avsm mentioned this issue Mar 25, 2019
Merged
yomimono pushed a commit to yomimono/opam-repository that referenced this issue Apr 5, 2019
@avsm @yomimono
[new release] cstruct-async, ppx_cstruct, cstruct, cstruct-unix, cstr…
bad607b 
…uct-sexp and cstruct-lwt (4.0.0)

CHANGES:

- Sexplib is now an optional library for the base `Cstruct` module.
  A new `Cstruct_sexp` module has been introduced with the serialiser
  functions, contained within the `cstruct-sexp` opam package.

  To convert old code, simply use `Cstruct_sexp.t` instead of
  `Cstruct.t` in a record type for which you are using `[@@deriving sexp]`.
  This is a type alias to `Cstruct.t` but also has the right
  sexp-conversion functions in scope.  There is an example of this
  in the `ppx_test/with-sexp` directory in the source repo.

  When you have converted and released your library, add an
  opam constraint of `cstruct {>="4.0.0"}` to your own opam
  packages to ensure that they pick up this version of the library.
  (fixes mirage/ocaml-cstruct#222, @avsm)

- JavaScript stubs are now installed using the jsoo mechanism
  rather than a manual specification (mirage/ocaml-cstruct#241 @jonludlam)

- Use computed versions in opam files to ensure that dependent
  opam packages such as cstruct-async get the same base version
  of cstruct to avoid mismatches. (@avsm)

- Add a ppx test suite to checks that all error paths in ppx
  handling are reachable and have meaningful location info (mirage/ocaml-cstruct#238 @emillon)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@avsm @hannesm