Dns.Dnskey.pp_name_key and Dns.Dnskey.name_key_of_string are not isomorph

[dinosaure]

Actually used in tlstunnel:

          D.retrieve_certificate pub ~dns_key:(Fmt.to_to_string Dns.Dnskey.pp_name_key (K.dns_key ()))

It seems that Dns.Dnskey.pp_name_key does not put the ::

ocaml-dns/src/dns.ml

Lines 911 to 912 in 0d7fe18

	let pp_name_key ppf (name, key) =
	Fmt.pf ppf "%a %a" Domain_name.pp name pp key

Which seems required for Dns.Dnskey.name_key_of_string:

ocaml-dns/src/dns.ml

Lines 903 to 909 in 0d7fe18

	let name_key_of_string str =
	match String.split_on_char ':' str with
	| name :: key ->
	let* name = Domain_name.of_string name in
	let* dnskey = of_string (String.concat ":" key) in
	Ok (name, dnskey)
	| [] -> Error (`Msg ("couldn't parse name:key in " ^ str))

Not sure why it's work for tlstunnel but it does not work on my STMP stack.

[hannesm]

Thanks. So, I digged a bit deeper, and it never worked for tlstunnel. Thanks for discovering this issue. I opened #356 to provide such dual functions.

[hannesm]

We didn't notice in tlstunnel since we're still using an old image which predates the change (introduced in robur-coop/tlstunnel@b9a7183) -- before that it was just a string.