Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS-over-TLS (7858) for the dns-client: With_tls functor #267

Closed
wants to merge 3 commits into from

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Aug 18, 2021

This adds DNS-over-TLS (RFC 7858) to the dns-client. This compiles, but have not been tested (and clients need to be adapted, esp. the TLS authenticator needs to be provided).

@hannesm
Copy link
Member Author

hannesm commented Aug 18, 2021

/cc @cfcs if you're interested.. I'm not yet sure whether adding "tls" as hard dependency to dns-client is good, but the alternative (more opam packages) doesn't feel good either. Eventually a tls-build-time-dependency is fine, and the compiler should be smart enough (with link-time-optimization -- ocaml/ocaml#608) at some point to remove the code at link time.

@hannesm
Copy link
Member Author

hannesm commented Aug 18, 2021

mostly a proof of concept here, but:

  • odns works (with various public resolvers)

what is left to be done: provide command-line arguments for authenticator (trust anchors, public key (or cert) fingerprints, evenually hostname) -- eventually there should be a post-resolving authentication with dnssec, and dane (see https://datatracker.ietf.org/doc/html/rfc8310#section-6 for details)

- default to Ca_certs.authenticator
- trust anchor file
- public key fingerprint
- certificate fingerprint

additionally, provide a "--ns-hostname" argument to validate the hostname
@hannesm
Copy link
Member Author

hannesm commented Aug 19, 2021

with f6fabea the odns tool supports dns-over-tls, including command line arguments for the various authentication mechanisms.

@hannesm hannesm changed the title client: With_tls functor DNS-ovr-TLS (7858) for the dns-client: With_tls functor Aug 19, 2021
@hannesm hannesm changed the title DNS-ovr-TLS (7858) for the dns-client: With_tls functor DNS-over-TLS (7858) for the dns-client: With_tls functor Aug 19, 2021
@hannesm
Copy link
Member Author

hannesm commented Oct 5, 2021

This was an interesting prototype, but with #269 being merged we need to rework it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant