-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decompress in ocaml-git #145
Conversation
Do you have some benchmarks? If perf hit is not too bad I'm happy to use it as the default and make camlzip an optional dependency. |
Can you also add the dependency to the |
Hmmhmm, Decompress is only available on ocaml |
What's the status of that PR? I think I'd like to keep an optional dependency to Decompress for now on, as I'd like to be fully convinced on the robustness of Decompress first. Also, the performance hit is still noticeable, so it still makes sense to keep using zlib for a bit (I can easily be convinced to switch fully to Decompress at one point, though) |
Yes, I have lot of work for the moment (on MrMime) so you can close the PR and when I have the time to optimize Decompress, I come back with an optionnal dependency 👍 ! |
Superseed mirage#145
Superseed mirage#145
Superseed mirage#145
Superseed mirage#145
I don't know if you want a strong dependency with decompress or a weak dependency. I will do a release tomorow (just fix a bug with reverse stub in decompress, but this does not concern you :) ).