Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decompress in ocaml-git #145

Closed
wants to merge 2 commits into from
Closed

Conversation

dinosaure
Copy link
Member

I don't know if you want a strong dependency with decompress or a weak dependency. I will do a release tomorow (just fix a bug with reverse stub in decompress, but this does not concern you :) ).

@samoht
Copy link
Member

samoht commented Mar 29, 2016

Do you have some benchmarks? If perf hit is not too bad I'm happy to use it as the default and make camlzip an optional dependency.

@samoht
Copy link
Member

samoht commented Mar 29, 2016

Can you also add the dependency to the opam file? Thanks!

@dinosaure
Copy link
Member Author

Hmmhmm, Decompress is only available on ocaml >= 4.02.0 (-safe-string, Bytes, blabla). You want a version on 4.01.0 ?

@samoht
Copy link
Member

samoht commented May 3, 2016

What's the status of that PR? I think I'd like to keep an optional dependency to Decompress for now on, as I'd like to be fully convinced on the robustness of Decompress first. Also, the performance hit is still noticeable, so it still makes sense to keep using zlib for a bit (I can easily be convinced to switch fully to Decompress at one point, though)

@dinosaure
Copy link
Member Author

Yes, I have lot of work for the moment (on MrMime) so you can close the PR and when I have the time to optimize Decompress, I come back with an optionnal dependency 👍 !

samoht added a commit to samoht/ocaml-git that referenced this pull request May 11, 2017
@samoht samoht mentioned this pull request May 11, 2017
samoht added a commit to samoht/ocaml-git that referenced this pull request May 11, 2017
@dinosaure dinosaure closed this May 12, 2017
@dinosaure dinosaure deleted the decompress branch May 12, 2017 08:29
samoht added a commit to dinosaure/ocaml-git that referenced this pull request May 12, 2017
samoht added a commit to dinosaure/ocaml-git that referenced this pull request May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants