Link with logs and logs.fmt #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but how you get the linking problem? |
|
Just compiling ocaml-git in my switch or installing it as a dependency via |
That weird that the CI did not catch it. Let's merge, thanks! |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Dec 13, 2021
… git-mirage (3.7.0) CHANGES: - Drop unneeded `mirage-protocols` dependency (@hannesm, mirage/ocaml-git#537) - Delete HTTP functor and use happy-eyeballs (@dinosaure, mirage/ocaml-git#539) - Be compatible with `mirage-protocols.7.0.0` (@dinosaure, mirage/ocaml-git#541) - Use `Lwt.pause` instead of `Lwt_unix.yield` (@dinosaure, mirage/ocaml-git#542) - Link with logs and `logs.fmt` (@MisterDA, mirage/ocaml-git#544)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Dec 15, 2021
…nd git-unix (3.7.0) CHANGES: - Drop unneeded `mirage-protocols` dependency (@hannesm, mirage/ocaml-git#537) - Delete HTTP functor and use happy-eyeballs (@dinosaure, mirage/ocaml-git#539) - Be compatible with `mirage-protocols.7.0.0` (@dinosaure, mirage/ocaml-git#541) - Use `Lwt.pause` instead of `Lwt_unix.yield` (@dinosaure, mirage/ocaml-git#542) - Link with logs and `logs.fmt` (@MisterDA, mirage/ocaml-git#544)
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Dec 23, 2021
CHANGES: - Drop unneeded `mirage-protocols` dependency (@hannesm, mirage/ocaml-git#537) - Delete HTTP functor and use happy-eyeballs (@dinosaure, mirage/ocaml-git#539) - Be compatible with `mirage-protocols.7.0.0` (@dinosaure, mirage/ocaml-git#541) - Use `Lwt.pause` instead of `Lwt_unix.yield` (@dinosaure, mirage/ocaml-git#542) - Link with logs and `logs.fmt` (@MisterDA, mirage/ocaml-git#544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a couple of places where the link with
logsorlogs.fmtwas forgotten in 3.6.0. This breaks the package installation in my opam switch :/