Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use implicit executable dependency for gen_services.exe #151

Merged
merged 1 commit into from
Nov 25, 2020

Conversation

TheLortex
Copy link
Member

Explicit executable dependencies make dune fail in cross-compilation settings.
More info in ocaml/dune#3917.

Copy link
Member

@dinosaure dinosaure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinosaure dinosaure merged commit 4a2b228 into mirage:master Nov 25, 2020
dinosaure added a commit to dinosaure/opam-repository that referenced this pull request Jan 5, 2021
CHANGES:

* `uri-re` is deprecated, it is a legacy implementation that is now outdated.
  `uri` should be used instead (@dinosaure, mirage/ocaml-uri#152).
* Fix build system for cross-compilation (@TheLortex, mirage/ocaml-uri#151).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants