Fix Repr.pre_hash to rely on itself recursively
#71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that custom `pre_hash` functions attached to components of larger types are not ignored.
|
This feature is a pre-requisite of mirage/irmin#1389. |
Ngoguey42
reviewed
Aug 23, 2021
Ngoguey42
reviewed
Aug 23, 2021
craigfe
force-pushed
the
recursive-pre-hash
branch
from
554ff36 to
cfe7c3e
Compare
Ngoguey42
reviewed
Aug 24, 2021
Ngoguey42
reviewed
Aug 24, 2021
Ngoguey42
approved these changes
Aug 24, 2021
|
Thanks @Ngoguey42 for the review. |
craigfe
added a commit
to craigfe/irmin
that referenced
this pull request
Sep 3, 2021
This revision contains the fix to recursive pre-hashing here: mirage/repr#71.
This was referenced Sep 3, 2021
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Oct 12, 2021
CHANGES: - Add `Repr.int63`, a representation of the `Optint.Int63.t` type (provided by the `optint` library). (mirage/repr#80, @craigfe) - Change `Repr.{like,map,partially_abstract}` functions to not require `_ staged` wrappers around any (monomorphic) overrides. (mirage/repr#77, @craigfe) - Fix a bug causing custom `Repr.{random,random_state}` implementations to be ignored. (mirage/repr#79, @craigfe) - Fix `Repr.pre_hash` to rely on itself recursively. This ensures that custom `pre_hash` functions attached to components of larger types are not ignored. (mirage/repr#71, @craigfe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that custom
pre_hashfunctions attached to components of larger types are not ignored.Fix #39.