Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated for trackRequests, testConfig and baseConfig #2375

Merged
merged 4 commits into from
Apr 13, 2022

Conversation

cah-brian-gantzler
Copy link
Collaborator

Removed the trackRequest option. Updated docs to show how to use with MirageJS.
Removed the testConfig option for startMirage. Never documented.
Removed some references to baseConfig that should have been removed when makeServer was made the only way to create the server.

@cah-brian-gantzler
Copy link
Collaborator Author

Prettier got me again. I dont think I changed that line, but I did change the file :( Will wait til all the tests are done in case there is something more and then will update

@bgantzler bgantzler force-pushed the remove-reprecations branch from 31d4b35 to 545147f Compare March 23, 2022 21:05
@kevinansfield
Copy link

Does testConfig need to be removed? We use it quite a bit as it allows us to mock only the in-development API endpoints for new features whilst developing without having to opt-in to the whole of the system being mocked.

I thought that was documented at some point, or at least included in the default generated config file 🤔 Looking back to 2015 when we first added ember-cli-mirage the following was at the bottom of our config:

/*
 You can optionally export a config that is only loaded during tests
 export function testConfig() {

 }
 */

@cah-brian-gantzler
Copy link
Collaborator Author

Kevin,

Please see issue #2377

I created it to answer your question. Figured more people would find the answer in issues rather than in PR comments.

@cah-brian-gantzler cah-brian-gantzler merged commit 83a1c95 into miragejs:master Apr 13, 2022
@cah-brian-gantzler cah-brian-gantzler deleted the remove-reprecations branch April 13, 2022 18:15
@SergeAstapov SergeAstapov changed the title Remove deprecations for trackRequests, testConfig and baseConfig Remove deprecated for trackRequests, testConfig and baseConfig Apr 13, 2022
@SergeAstapov SergeAstapov added the Breaking Pull requests that include breaking changes label Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Pull requests that include breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants