Extract docs into separate app #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
commented
Apr 22, 2022
| "@types/qunit": "^2.11.3", | ||
| "babel-eslint": "^10.1.0", | ||
| "broccoli-asset-rev": "^3.0.0", | ||
| "ember-cli": "~4.1.0", | ||
| "ember-cli-addon-docs": "github:ember-learn/ember-cli-addon-docs#36a989bd112e8c2ae27c375eef6f7796c8a5dc28", |
There was a problem hiding this comment.
this is the biggest benefit of this PR
SergeAstapov
force-pushed
the
extract-docs-app
branch
from
fc6fbb5 to
dee1425
Compare
|
It looked weird, I thought you had failed to delete some files, but I think its because the test app hasnt been extracted from the package, just the docs. |
cah-brian-gantzler
approved these changes
Apr 23, 2022
This usually is done when addon converted to v2 format and we are not there yet. |
francois2metz
pushed a commit
to francois2metz/ember-cli-mirage
that referenced
this pull request
Dec 19, 2023
Extract docs into separate app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #2395