Feature/profile settings and updates #12
Open
+218
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
take-2405
commented
Oct 9, 2020
api2/pkg/server/controller/user.go
Outdated
Comment on lines
13
to
18
| user model.User | ||
| name model.User | ||
| image model.User | ||
| year model.User | ||
| month model.User | ||
| gender model.User |
There was a problem hiding this comment.
一つで十分
user.Idとかで参照できる
api2/pkg/server/controller/user.go
Outdated
| ) | ||
|
|
||
| //ユーザー情報 | ||
| func HandleUserSet() gin.HandlerFunc { | ||
| return func(c *gin.Context) { |
There was a problem hiding this comment.
gin.contextをcと定義してるので以下の部分でcontextとなっている部分をcにするかもしくはここをcontextにするか
api2/pkg/server/controller/user.go
Outdated
| return func(c *gin.Context) { | ||
| if err := context.BindJSON(&HandleUserSet); err != nil { |
There was a problem hiding this comment.
&HandleUserSet構造体を入れる必要がある
api2/pkg/server/controller/user.go
Outdated
| return | ||
| } | ||
| restoken.Token = uuid.String() | ||
| if err := HandleUserUpdate(HandleUserSet.Id, HandleUserSet.Name, HandleUserSet.Image, HandleUserSet.Year, HandleUserSet.Month HandleUserSet.Gender , restoken.Token); err != nil { |
There was a problem hiding this comment.
引数が関数になっているので構造体にする必要がある
api2/pkg/server/controller/user.go
Outdated
| return func(c *gin.Context) { | ||
| stmt, err := db.Con.Prepare("INSERT INTO UserSet VALUES (?,?,?)") |
There was a problem hiding this comment.
Mysqlのクエリが間違っている(?の数も足りない)
api2/pkg/server/controller/user.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| _, err = stmt.Exec(id, name, image, token, year, month, gender) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[担当者]
Resnsサーバー:堺
[目的]
ユーザーのプロフィール設定の機能
[レビューして欲しいところ]
機能が十分か
無駄な記述がないか