Underlying TRNG C++ library updated to v4.23(.1) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Via inst/tools/upgradeTRNG.R, extended to handle fetching TRNG from a GitHub release tag.
* Align to the outcome of the current version of `usethis::use_coverage()`. * This makes the status checks informational, see https://docs.codecov.io/docs/commit-status for reference.
|
This also includes a small maintenance on the codecov side to align to the standard settings one would obtain with |
riccardoporreca
changed the title
|
@RolandASc, I am going to integrate the changes done in a patch of TRNG 4.23 upstream (see #16 (comment)) in this branch, so we include the patched 4.23.1 in this upgrade |
This was referenced Jan 29, 2021
Closed
* Based on the docker image `wch1/r-debug` and inspired by the CRAN checks logs for valgrind. * An artifact is produced containing the R CMD check output directory + a summary of the valgrind reported errors by file. * A failure is detected whenever a non-0 errors are found in any file. * The workflow is triggered on push and PRs on master, but can be triggered on any commit using [valgrind-check] in the comment. * The core bash script can be also executed locally, producing check results under `valgrind-check` (`.git`- and `.Rbuildignore`d).;
* Used to test backporting as a local patch of v4.23 the upstream TRNG fix rabauke/trng4@22cc3b6 addressing uninitialized memory issues reported by `valgrind` (#16), ahead of a proper patch release being available upstream. * The process is made reproducible by extending inst/tools/upgradeTRNG.R to consume and apply a patch file, adding a patch component to the version (e.g. 4.23.1), with an explicit mention in `TRNG.Version()` about this being a version patched inside rTRNG. [valgrind-check]
* Via inst/tools/upgradeTRNG.R * The patch release fixes the uninitialized-memory problems reported as `valgrind` issues in the CRAN package checks for rTRNG 4.20-1 (closes #16). [valgrind-check]
* To ensure the workflow is executed on PRs to master, w/o requiring a [valgrind-check] commit message, as originally intended.
* Via inst/tools/upgradeTRNG.R, extended to rely on the GitHub release tag for newer versions, and exposing a `year` argument.
|
@RolandASc, I am going to merge this after including #21, I don't expect many functional aspects of the additional changed to be reviewed at this stage, and a final review will be done on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #18 for the intended upgrade to v4.23, and #21 for the the inclusion of the patch release v4.23.1, which fixes #16
In particular, the efforts described in #16 around reproducing and assessing
valgrindissues based on the Docker image wch1/r-debug have been consolidated into a new GH actions workflow to automate such checks.