Really fix the performance issue with projects stats

mirego · Apr 4, 2024 · 8f18349 · 8f18349
1 parent d8b042e
commit 8f18349
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 10 deletions.
diff --git a/lib/graphql/resolvers/project.ex b/lib/graphql/resolvers/project.ex
@@ -85,9 +85,8 @@ defmodule Accent.GraphQL.Resolvers.Project do
       Project
       |> Query.join(:inner, [p], c in assoc(p, :collaborators))
       |> Query.where([_, c], c.user_id == ^viewer.id)
-      |> Query.order_by([p, _], asc: p.name)
+      |> Query.order_by([p, _], desc_nulls_first: p.last_synced_at)
       |> ProjectScope.from_search(args[:query])
-      |> ProjectScope.with_stats()
       |> Paginated.paginate(args)
       |> Paginated.format()
 
@@ -96,7 +95,6 @@ defmodule Accent.GraphQL.Resolvers.Project do
       |> Query.join(:inner, [p], c in assoc(p, :collaborators))
       |> Query.where([_, c], c.user_id == ^viewer.id)
       |> ProjectScope.from_ids(args[:node_ids])
-      |> ProjectScope.with_stats()
       |> Repo.all()
 
     projects = Map.put(paginated_projects, :nodes, nodes_projects)

diff --git a/test/graphql/requests/projects_request_test.exs b/test/graphql/requests/projects_request_test.exs
@@ -35,9 +35,6 @@ defmodule AccentTest.GraphQL.Requests.Projects do
                 id
                 name
                 lastSyncedAt
-                translationsCount
-                conflictsCount
-                reviewedCount
               }
             }
           }
@@ -52,9 +49,5 @@ defmodule AccentTest.GraphQL.Requests.Projects do
 
     assert get_in(data, [:data, "viewer", "projects", "entries", Access.at(0), "lastSyncedAt"]) ===
              "2017-01-01T00:00:00Z"
-
-    assert get_in(data, [:data, "viewer", "projects", "entries", Access.at(0), "translationsCount"]) === 3
-    assert get_in(data, [:data, "viewer", "projects", "entries", Access.at(0), "reviewedCount"]) === 1
-    assert get_in(data, [:data, "viewer", "projects", "entries", Access.at(0), "conflictsCount"]) === 2
   end
 end