Skip to content

Commit

Permalink
require sexplib < v0.11.0 to avoid base dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
@hannesm
hannesm committed Apr 28, 2018
1 parent 79b6a6f commit 0dc2591
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion opam
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ depends: [
"topkg" {build}
"result"
"cstruct" {>= "1.6.0"}
"sexplib"
"sexplib" {< "v0.11.0"}
"asn1-combinators" {>= "0.2.0"}
"ptime"
"nocrypto" {>= "0.5.3"}
Expand Down

2 comments on commit 0dc2591

@samoht
Copy link

@samoht samoht commented on 0dc2591 Apr 29, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the rational for this change, but you might be interested by https://github.com/janestreet/sexplib0

@hannesm
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samoht motivation is ocaml/opam-repository#11852 (comment) -- I don't think depending on base is a wise idea (due to its size). but it should be a constraint of ppx_sexp_conv rather than sexplib.

Please sign in to comment.