Pretty printers for extensions #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 10, 2019
CHANGES: * export X509.Distinguished_name.common_name : t -> string option, which extracts the common name of a distinguished name * Distinguished_name.t is now a Relative_distinguished_name.t list, a Relative_distinguished_name is a Set.S with element type attribute, a variant. It used to be an attribute (expressed as GADT) Gmap.t, but this representation did not conform to RFC 5280, reported by @paurkedal (mirleft/ocaml-x509#117, fixed by mirleft/ocaml-x509#118) * Now using Set.find_first_opt, which bumps lower OCaml bound to 4.05.0 * Improved pretty-printing for DNs including RFC 4514 conformance (@paurkedal, mirleft/ocaml-x509#119). * Extension.pp now outputs extension key and its value (mirleft/ocaml-x509#120) * rename Distinguished_name.SP constructor (stateOrProvince) to ST, as widely used (mirleft/ocaml-x509#121) * support Street and UID in Distinguished_name to satisfy RFC 4514 demands (mirleft/ocaml-x509#121)
This was referenced Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also expose
Distinguished_name.common_name : t -> string option(I have some revdeps which use exactly this) //cc @paurkedal