simplify fingerprint validation and authentication: pass a single fingerprint #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gerprint Previously a list of name and fingerprint was passed, which was not used at all. In practice, a single fingerprint is sufficient. With this change, providing the fingerprint of a certificate that is valid for certain IP addresses will work nicely (similar to what mirleft#152 does for chain of trust).
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 27, 2021
CHANGES: * FEATURE support validation of an IP address in the leaf certificate (mirleft/ocaml-x509#152 mirleft/ocaml-x509#153 @reynir @hannesm) * FEATURE provide Certificate.ips and Certificate.supports_ip (mirleft/ocaml-x509#152 @reynir @hannesm) * BREAKING revise certificate and public key fingerprint authenticators API: now a single fingerprint is supported, previously a list of pairs of hostname and fingerprint was used (mirleft/ocaml-x509#153 @hannesm) * BREAKING The Authenticator.t type has been extended with ?ip:Ipaddr.t (mirleft/ocaml-x509#153 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a list of name and fingerprint was passed, which was not used at all.
In practice, a single fingerprint is sufficient. With this change, providing the
fingerprint of a certificate that is valid for certain IP addresses will work
nicely (similar to what #152 does for chain of trust).
//cc @reynir