fix the serial rng #179
Merged
fix the serial rng #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 (I agree with you about the recursive function). |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 29, 2024
CHANGES: * **breaking change** Allow decoding of negative serial numbers (mirleft/ocaml-x509#177 @hannesm) Now, `serial` returns the entire (integer) value as a string - previously the potentially leading 0 byte was removed. So: -serial d795 49bd 1a67 1751 +serial 00d7 9549 bd1a 6717 51 fixes in 38cc70a54d2d98526564733838769d82b10679fc and mirleft/ocaml-x509#179 (mirleft/ocaml-x509#178 @dinosaure) * Add alternate SHA1RSA OID 1.3.14.3.2.29 (mirleft/ocaml-x509#176 @mefyl) * Allow custom pretty printers for unknown X509 extensions (mirleft/ocaml-x509#175 @reynir) * Minor code cleanups: remove unused algorithms, remove `def` and `def'` (mirleft/ocaml-x509#177 @hannesm)
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Sep 29, 2024
CHANGES: * **breaking change** Allow decoding of negative serial numbers (mirleft/ocaml-x509#177 @hannesm) Now, `serial` returns the entire (integer) value as a string - previously the potentially leading 0 byte was removed. So: -serial d795 49bd 1a67 1751 +serial 00d7 9549 bd1a 6717 51 fixes in 38cc70a54d2d98526564733838769d82b10679fc and mirleft/ocaml-x509#179 (mirleft/ocaml-x509#178 @dinosaure) * Add alternate SHA1RSA OID 1.3.14.3.2.29 (mirleft/ocaml-x509#176 @mefyl) * Allow custom pretty printers for unknown X509 extensions (mirleft/ocaml-x509#175 @reynir) * Minor code cleanups: remove unused algorithms, remove `def` and `def'` (mirleft/ocaml-x509#177 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dinosaure -- I prefer this over #178, the reason being that I'm scared of introducing recursive functions.
would be great if you could have a look at this!?