Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TravisCI with Github Actions #131

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Replace TravisCI with Github Actions #131

merged 1 commit into from
Dec 27, 2023

Conversation

MasterOdin
Copy link
Contributor

@MasterOdin MasterOdin commented Dec 27, 2023

PR replaces the TravisCI configuration (which has not run in over a year) with one for Github Actions. This retains essentially all the same pieces of what Travis was doing, though with tweaks to get things to work in the "GH actions" way (e.g. such as using coveralls workflow, vs the npm coveralls package). See https://github.com/MasterOdin/react-redux-loading-bar/actions/runs/7335355578/ for what this looks like, where it's hooked up to upload to https://coveralls.io/github/MasterOdin/react-redux-loading-bar.

One suggestion would be to drop the usage of test:coveralls where doing | coveralls eats the test input, but instead use test:coverage (with --reporter=lcov), and then use coverallsapp/github-action to upload the coverage report, as it gives you the full test output, as is the more "blessed" way to do this, and avoids having to know to setup the COVERALLS_REPO_TOKEN value.

@mironov
Copy link
Owner

mironov commented Dec 27, 2023

@MasterOdin Hey, thank you for migrating the CI configuration! Your suggestion about refactoring coveralls integration also makes sense. Unfortunately, I don't have the capacity to do that, but I'd be happy to accept a pull request.

@mironov mironov merged commit 8818099 into mironov:master Dec 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants