Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export constants from reducer #132

Merged
merged 1 commit into from
Dec 27, 2023
Merged

Re-export constants from reducer #132

merged 1 commit into from
Dec 27, 2023

Conversation

MasterOdin
Copy link
Contributor

PR makes it so that the constants (DEFAULT_SCOPE, HIDE, RESET, SHOW) from the reducer file so that downstream libraries can use them.

In our application, we want to implement our own version of loadingBarReducer where the state is a simple toggle, vs it being a counter, and having these be a top level exports would simplify things / give us confidence that our implementation won't break on us.

Signed-off-by: Matthew Peveler <matt@popsql.com>
@mironov
Copy link
Owner

mironov commented Dec 27, 2023

@MasterOdin Good idea, merging! Thank you.

@mironov mironov merged commit 9ab7792 into mironov:master Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants