[ES6 modules] Implement ModuleScript::RecordStatus()

This CL implements ModuleScript::RecordStatus(), which returns
module script's record's [[Status]].
Which will replace usage of ModuleScript::state_ after we switch to
the new #internal-module-script-graph-fetching procedure proposed
in the linked PRs.

The call to ScriptModule::Status routed via Modulator to allow
mock implementation in Modulator infra unit tests.

This codepath will be tested in modulator infra unit tests after
the #internal-module-script-graph-fetching update.

Bug: 594639, 727299, whatwg/html#2674 , tc39/ecma262#916
Change-Id: I2ca193a8c779945c9ae9b08c2b5f55de41fb1a3c
Reviewed-on: https://chromium-review.googlesource.com/558724
Commit-Queue: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483902}

third_party/WebKit/Source/core/dom/Modulator.h

@@ -5,6 +5,7 @@
 #ifndef Modulator_h
 #define Modulator_h
 
+#include "bindings/core/v8/ScriptModule.h"
 #include "core/CoreExport.h"
 #include "core/dom/AncestorList.h"
 #include "platform/bindings/ScriptWrappable.h"
@@ -22,7 +23,6 @@ class ExceptionState;
 class ModuleScript;
 class ModuleScriptFetchRequest;
 class ModuleScriptLoaderClient;
-class ScriptModule;
 class ScriptModuleResolver;
 class ScriptState;
 class ScriptValue;
@@ -123,6 +123,8 @@ class CORE_EXPORT Modulator : public GarbageCollectedFinalized<Modulator>,
 
   virtual ScriptValue InstantiateModule(ScriptModule) = 0;
 
+  virtual ScriptModuleState GetRecordStatus(ScriptModule) = 0;
+
   // https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-error
   virtual ScriptValue GetError(const ModuleScript*) = 0;
 

third_party/WebKit/Source/core/dom/ModulatorImpl.cpp

@@ -148,6 +148,11 @@ ScriptValue ModulatorImpl::InstantiateModule(ScriptModule script_module) {
   return script_module.Instantiate(script_state_.Get());
 }
 
+ScriptModuleState ModulatorImpl::GetRecordStatus(ScriptModule script_module) {
+  ScriptState::Scope scope(script_state_.Get());
+  return script_module.Status(script_state_.Get());
+}
+
 ScriptValue ModulatorImpl::GetError(const ModuleScript* module_script) {
   DCHECK(module_script);
   ScriptState::Scope scope(script_state_.Get());

third_party/WebKit/Source/core/dom/ModulatorImpl.h

@@ -66,6 +66,7 @@ class ModulatorImpl final : public Modulator {
                              const TextPosition&,
                              ExceptionState&) override;
   ScriptValue InstantiateModule(ScriptModule) override;
+  ScriptModuleState GetRecordStatus(ScriptModule) override;
   ScriptValue GetError(const ModuleScript*) override;
   Vector<ModuleRequest> ModuleRequestsFromScriptModule(ScriptModule) override;
   void ExecuteModule(const ModuleScript*) override;

third_party/WebKit/Source/core/dom/ModuleScript.cpp

@@ -184,6 +184,11 @@ bool ModuleScript::HasEmptyRecord() const {
   return record_.IsEmpty();
 }
 
+ScriptModuleState ModuleScript::RecordStatus() const {
+  DCHECK(!record_.IsEmpty());
+  return settings_object_->GetRecordStatus(Record());
+}
+
 void ModuleScript::SetErrorAndClearRecord(ScriptValue error) {
   DVLOG(1) << "ModuleScript[" << this << "]::SetErrorAndClearRecord()";
 

third_party/WebKit/Source/core/dom/ModuleScript.h

@@ -61,6 +61,9 @@ class CORE_EXPORT ModuleScript final : public Script, public TraceWrapperBase {
 
   ModuleInstantiationState State() const { return state_; }
 
+  // Corresponds to spec concept: module script's record's [[Status]]
+  ScriptModuleState RecordStatus() const;
+
   // https://html.spec.whatwg.org/multipage/webappapis.html#concept-module-script-is-errored
   bool IsErrored() const { return record_.IsEmpty(); }
 

third_party/WebKit/Source/core/testing/DummyModulator.cpp

@@ -115,6 +115,11 @@ ScriptValue DummyModulator::InstantiateModule(ScriptModule) {
   return ScriptValue();
 }
 
+ScriptModuleState DummyModulator::GetRecordStatus(ScriptModule) {
+  NOTREACHED();
+  return ScriptModuleState::kErrored;
+}
+
 ScriptValue DummyModulator::GetError(const ModuleScript*) {
   NOTREACHED();
   return ScriptValue();

third_party/WebKit/Source/core/testing/DummyModulator.h

@@ -58,6 +58,7 @@ class DummyModulator : public Modulator {
                              const TextPosition&,
                              ExceptionState&) override;
   ScriptValue InstantiateModule(ScriptModule) override;
+  ScriptModuleState GetRecordStatus(ScriptModule) override;
   ScriptValue GetError(const ModuleScript*) override;
   Vector<ModuleRequest> ModuleRequestsFromScriptModule(ScriptModule) override;
   void ExecuteModule(const ModuleScript*) override;