Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This little change does fix a verbose+dangerous warning #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ebachard
Copy link

@ebachard ebachard commented Aug 10, 2021

Hello,

Building x264 code on Linux Intel (x86_64) caused a long warning. This fix is a suggestion to fix the issue (see the log below)

Feel free to accept (or not this change) under MIT license (ask me something else if you need).

Thanks a lot for sharing the code, and thank you very much for providing such features :-)

Eric Bachard

The log containing the warning:

encoder/rdo.c: In function ‘x264_8_quant_8x8_trellis’:
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
             for( i = start; i <= end; i+=step )
             ^~~
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
encoder/rdo.c:1088:13: warning: assuming signed overflow does not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]

@ebachard ebachard changed the title This changes does fix a verbose+dangerous warning This little change does fix a verbose+dangerous warning Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant