-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Pin dependencies to make CI pass #331
base: main
Are you sure you want to change the base?
Conversation
@@ -25,7 +25,7 @@ dependencies = [ | |||
"click~=8.1", | |||
"graphql-core>=3.2.0,<3.3", | |||
"toml~=0.10", | |||
"httpx~=0.23", | |||
"httpx<=0.27.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned due to app
being deprecated in 0.28.0
"mypy", | ||
"types-toml", | ||
"pytest-mock", | ||
"pytest-asyncio", | ||
"pytest-httpx", | ||
"pytest-httpx<=0.34.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned due to requiring httpx==0.28.0
since 0.35.0
@@ -36,12 +36,12 @@ dependencies = [ | |||
dev = [ | |||
"ariadne", | |||
"pytest", | |||
"pylint", | |||
"pylint==3.2.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned due to a bunch of fixes and changes in 3.3.0
I had to pin 3 dependencies to get this PR green but I wonder if we should take a bigger stab and pin everything. Feels like it's been breaking a few times and CI hasn't been green in 3 months. For now, I only pinned the bare minimum but feel free to use this branch to pin everything. I wonder if while we're at it we should also create som setup instructions. I used a bare I also suggest moving to Let me know if you want any assistance with this or prefer to not do anything or do your own setup! |
This fixes spelling of "behavior". I actually don't know where this is coming from or why the test failed but they failed both locally and in CI so this will change the spelling.