fix corner case in merge_vars (#5830)

fixes #5829
mishoo · Jun 8, 2024 · 2cb6454 · 2cb6454
1 parent 0991077
commit 2cb6454
Show file tree

Hide file tree

Showing 2 changed files with 43 additions and 1 deletion.
diff --git a/lib/compress.js b/lib/compress.js
@@ -6719,9 +6719,11 @@ Compressor.prototype.compress = function(node) {
                     segments.consequent = scan_branches(level + 1, condition.left, condition.right).consequent;
                     break;
                   case "||":
-                  case "??":
                     segments.alternative = scan_branches(level + 1, condition.left, null, condition.right).alternative;
                     break;
+                  case "??":
+                    segments.alternative = scan_branches(level + 1, condition.left, condition.right, condition.right).alternative;
+                    break;
                   default:
                     condition.walk(tw);
                     break;

diff --git a/test/compress/nullish.js b/test/compress/nullish.js
@@ -344,3 +344,43 @@ issue_5266: {
     ]
     node_version: ">=14"
 }
+
+issue_5829_1: {
+    options = {
+        merge_vars: true,
+    }
+    input: {
+        (function f(a) {
+            var b;
+            (!a ?? (b = 0)) || console.log(b || "PASS");
+        })("FAIL");
+    }
+    expect: {
+        (function f(a) {
+            var b;
+            (!a ?? (b = 0)) || console.log(b || "PASS");
+        })("FAIL");
+    }
+    expect_stdout: "PASS"
+    node_version: ">=14"
+}
+
+issue_5829_2: {
+    options = {
+        merge_vars: true,
+    }
+    input: {
+        (function f(a) {
+            var b;
+            (a ?? (b = 0)) && console.log(b || "PASS");
+        })("FAIL");
+    }
+    expect: {
+        (function f(a) {
+            var b;
+            (a ?? (b = 0)) && console.log(b || "PASS");
+        })("FAIL");
+    }
+    expect_stdout: "PASS"
+    node_version: ">=14"
+}