Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle exceptional flow correctly in collapse_vars #2574

Merged
merged 1 commit into from
Dec 10, 2017

Conversation

alexlamsl
Copy link
Collaborator

fixes #2571

@alexlamsl alexlamsl merged commit 0e16d92 into mishoo:master Dec 10, 2017
@alexlamsl alexlamsl deleted the issue-2571 branch December 10, 2017 16:16
@kzc
Copy link
Contributor

kzc commented Dec 10, 2017

Just curious - how was this issue related to switch cases?

@alexlamsl
Copy link
Collaborator Author

Glad you asked - the previous (buggy) behaviour of collapse_vars also leads to an incorrect workaround for walking through AST_Switch - fixing this exceptional side effects issue makes that no longer effective.

@kzc
Copy link
Contributor

kzc commented Dec 10, 2017

A few extra classes may have to handled in AST_Node.may_throw() in harmony? Or is the default safe? I suppose it's an optimization opportunity to refine some harmony behaviors.

@alexlamsl
Copy link
Collaborator Author

harmony should work correctly albeit sub-optimally.

@alexlamsl
Copy link
Collaborator Author

OT: if JavaScript supports inter-scope/expression goto this would have been a nightmare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ufuzz: collapse_vars bug
2 participants