Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use the deprecated Buffer() constructor #3277

Closed
wants to merge 1 commit into from
Closed

Do not use the deprecated Buffer() constructor #3277

wants to merge 1 commit into from

Conversation

lpinca
Copy link

@lpinca lpinca commented Oct 16, 2018

@LongTengDao
Copy link

Why use Buffer.from !== Uint8Array.from check?

@lpinca
Copy link
Author

lpinca commented Nov 15, 2018

@LongTengDao becuase Buffer extends Uint8Array and we need to check that Buffer.from is not the inherited one.

@LongTengDao
Copy link

LongTengDao commented Nov 16, 2018 •
edited
Loading

thank you.

@LongTengDao LongTengDao mentioned this pull request Nov 16, 2018
Closed
alexlamsl added a commit to alexlamsl/UglifyJS that referenced this pull request Oct 10, 2019
@alexlamsl
improve source map handling
a2dfe94 
fixes mishoo#2947
fixes mishoo#3277
fixes mishoo#3411
@alexlamsl alexlamsl mentioned this pull request Oct 10, 2019
Merged
alexlamsl added a commit that referenced this pull request Oct 10, 2019
@alexlamsl
improve source map handling (#3464)
6d57ca1 
fixes #2947
fixes #3277
fixes #3411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lpinca @LongTengDao