Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace deprecated String.prototype.substr() #5384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CommanderRoot
Copy link

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.

Breaking Changes

None

.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated
Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
@alexlamsl
Copy link
Collaborator

This doesn't seem to be fixing any bugs − unless you can demonstrate with a test case that fails before and passes after this PR.

Thanks for taking the time, although as you stated these whimsical deprecations never results in any removal (see __proto__) so I don't see the need, unless this gives measureable performance boost on some platforms (without regression in others).

@CommanderRoot
Copy link
Author

It removes a deprecation warning in the IDE. But you're right, unless the function gets removed by browsers or other software which uses this code there is nothing broken.
As for performance, I have not tested it directly but from looking at other repos it's basically the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants