Skip to content

Commit

Permalink
pythongh-126417: validate ABC methods on multiprocessing proxy types (p…
Browse files Browse the repository at this point in the history
…ython#126454)

Checks that appropriate dunder __ methods exist on the dict and list proxy types.

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
  • Loading branch information
tungol and AlexWaygood authored Nov 11, 2024
1 parent 82269c7 commit 6ee542d
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions Lib/test/_test_multiprocessing.py
Original file line number Diff line number Diff line change
Expand Up @@ -2464,6 +2464,19 @@ def test_list_isinstance(self):
a = self.list()
self.assertIsInstance(a, collections.abc.MutableSequence)

# MutableSequence also has __iter__, but we can iterate over
# ListProxy using __getitem__ instead. Adding __iter__ to ListProxy
# would change the behavior of a list modified during iteration.
mutable_sequence_methods = (
'__contains__', '__delitem__', '__getitem__', '__iadd__',
'__len__', '__reversed__', '__setitem__', 'append',
'clear', 'count', 'extend', 'index', 'insert', 'pop', 'remove',
'reverse',
)
for name in mutable_sequence_methods:
with self.subTest(name=name):
self.assertTrue(callable(getattr(a, name)))

def test_list_iter(self):
a = self.list(list(range(10)))
it = iter(a)
Expand Down Expand Up @@ -2508,6 +2521,15 @@ def test_dict_isinstance(self):
a = self.dict()
self.assertIsInstance(a, collections.abc.MutableMapping)

mutable_mapping_methods = (
'__contains__', '__delitem__', '__eq__', '__getitem__', '__iter__',
'__len__', '__ne__', '__setitem__', 'clear', 'get', 'items',
'keys', 'pop', 'popitem', 'setdefault', 'update', 'values',
)
for name in mutable_mapping_methods:
with self.subTest(name=name):
self.assertTrue(callable(getattr(a, name)))

def test_dict_iter(self):
d = self.dict()
indices = list(range(65, 70))
Expand Down

0 comments on commit 6ee542d

Please sign in to comment.