Segment display emulator #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows the effect to work properly in Windows (all Kivy effects use the same texture2D deprecated function)
|
It looks like my "fix" to the glow effects to support Windows breaks it on linux. I should just revert that for now and leave that as a separate issue as it is not directly related to this PR. |
The glow effect is broken on some platforms.
jabdoa2
approved these changes
Apr 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for a new virtual segment display emulator (also related PRs for MPF-MC and docs). Uses virtual hardware platform segment display to update new segment_display_emulator widget in the MC. Supports the new color feature added for the Fast segment displays. The segment display widgets can be updated using the segment_display_player.
The widget_player can be used to update the new segment_display_emulator widgets, but it is not the recommended way to control these as the widget_player destroys and re-creates widgets when they are updated and that is a much more expensive operation than using the segment_display_player.
Still have some more advanced features to add (transition effects, individual character colors), but wanted to get this pulled into the code base first.