Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 8 segment displays to emulator #429

Merged
merged 2 commits into from
Nov 17, 2021
Merged

add 8 segment displays to emulator #429

merged 2 commits into from
Nov 17, 2021

Conversation

borgdog
Copy link
Contributor

@borgdog borgdog commented Nov 8, 2021

initial setup of 8 segment displays for virtual emulator. I attempted to shape the crossing segments better, but it didn't seem to want to do that and I'm not sure how it fills between the points so may have something wrong. this does work but I have not extensively tested it for different sizes and bevels etc.

@jabdoa2
Copy link
Collaborator

jabdoa2 commented Nov 17, 2021

Linter is unhappy. Can you fix those?

Messages

========

mpfmc/widgets/segment_display_emulator.py

  Line: 299

    pep8: E127 / continuation line over-indented for visual indent (col 44)

    pep8: E127 / continuation line over-indented for visual indent (col 44)

  Line: 300

    pep8: E127 / continuation line over-indented for visual indent (col 44)

    pep8: E127 / continuation line over-indented for visual indent (col 44)

  Line: 305

    pylint: unused-variable / Unused variable 'segment_factor' (col 8)

  Line: 306

    pylint: unused-variable / Unused variable 'diagonal_slope' (col 8)

  Line: 318

    pep8: E201 / whitespace after '[' (col 33)

    pep8: E262 / inline comment should start with '# ' (col 89)

    pep8: E201 / whitespace after '[' (col 33)

    pep8: E262 / inline comment should start with '# ' (col 89)

    pylint: bad-whitespace / No space allowed after bracket

                          "g": [ x[3] - segment_interval / 2 * sqrt3, y[3],             #right end

                               ^ (col 31)

  Line: 321

    pep8: W293 / blank line contains whitespace (col 1)

  Line: 322

    pep8: E262 / inline comment should start with '# ' (col 93)

    pep8: E262 / inline comment should start with '# ' (col 93)

  Line: 334

    pep8: E262 / inline comment should start with '# ' (col 73)

    pep8: E262 / inline comment should start with '# ' (col 73)

  Line: 336

    pep8: W293 / blank line contains whitespace (col 1)

  Line: 337

    pep8: E262 / inline comment should start with '# ' (col 84)

    pep8: E262 / inline comment should start with '# ' (col 84)

  Line: 339

    pep8: W293 / blank line contains whitespace (col 1)

  Line: 341

    pep8: E303 / too many blank lines (2) (col 9)

    pep8: E303 / too many blank lines (2) (col 9)

  Line: 346

    pep8: W293 / blank line contains whitespace (col 1)

@jabdoa2 jabdoa2 merged commit 6a7a37f into missionpinball:dev Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants