Allow missing mode folders in production mode #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried re-running the failed test machine a few times, looks to be a race condition that previous PRs have also failed on. Proceeding with merge due to low risk. |
avanwinkle
added a commit
to avanwinkle/mpf-mc
that referenced
this pull request
Sep 13, 2023
…-missing-folders Allow missing mode folders in production mode (cherry picked from commit 90f0917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small change to running MPF MC in
productionmode for optimized performance. During the production build, mode config files are consolidated into a single bundle and individual mode folders with modes/<mode_name>/config/<mode_name>.yaml files are not necessary.Without the need for individual config files, the exported machine code does not need separate folders for all modes. MPF manages just fine in this way, but MC throws on bootup because the mode folders are empty. This PR changes the MC startup code to allow missing mode folders while in production mode.
Caveat: Modes that have specific media assets, like
sounds:orvideos:still require having a mode folder with those subfolders for the assets. If the root mode folder is missing, skipping this check will expose a downstream error where an expected media file is missing. Perhaps an error on the media file instead of the mode folder is less helpful, but given the constraints I'm okay with it.