Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous updates: CoilPlayer, Bonus, BCP Service #1582

Merged
merged 4 commits into from
Jul 2, 2021

Conversation

avanwinkle
Copy link
Collaborator

This PR presents a handful of changes I've been carrying around in my local branch and never got around to merging. It's my last PR for the week, I promise! 😝

  • CoilPlayer now supports placeholders in the keys, so shows can use tokens to target coils. Very useful for adding flashers to shows.
  • Bonus Mode gets a new option skip_if_negative so that bonus calculations less than zero will be ignored, rather than subtracting from the player's score
  • BCP Clients can subscribe to service mode events as a group, instead of needing to get them all individually
  • Switch Diagnostics in the service menu will gracefully handle switches without labels (currently displays %)
  • Fast Drivers have fallbacks for hold_pwm_patter and recycle_ms not being present in the config

@avanwinkle avanwinkle requested a review from jabdoa2 July 2, 2021 19:13
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 2, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@avanwinkle avanwinkle merged commit cc04aee into missionpinball:dev Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants