handle autofire hw rules in a switch matrix #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrix switch based hw rules need to have the matrix columns mirrored since opp has reverse column order
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks! |
|
Maybe we should add a testcase for those numbers as well. Otherwise we might regress this in the future without noticing. |
|
If you give those functions a switch_num of 81 (0x51), it should send a command referencing switch 41 (0x29). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
matrix switch based hw rules need to have the matrix columns mirrored since opp has reverse column order