add 8 segment to display emulator #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabdoa2
requested changes
Nov 8, 2021
|
hmmm, I don't think I made those changes.. .I'll see if I can figure out
how to do that.
…On Mon, Nov 8, 2021 at 3:47 PM jabdoa2 ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Can you revert the other config_spec changes?
------------------------------
In mpf/config_spec.yaml
<#1617 (comment)>:
> @@ -479,7 +479,6 @@ drop_targets:
enable_keep_up_events: event_handler|event_handler:ms|None
disable_keep_up_events: event_handler|event_handler:ms|None
ball_search_order: single|int|100
- max_reset_attempts: single|int|None
Not sure if you wanted to remove this.
------------------------------
In mpf/config_spec.yaml
<#1617 (comment)>:
> @@ -488,7 +487,6 @@ drop_target_banks:
__valid_in__: machine, mode
__type__: device
drop_targets: list|machine(drop_targets)|
- max_reset_attempts: single|int|None
Same here.
------------------------------
In mpf/config_spec.yaml
<#1617 (comment)>:
> @@ -1019,7 +1017,6 @@ multiball_locks:
priority: single|int|1
reset_all_counts_events: event_handler|event_handler:ms|None
reset_count_for_current_player_events: event_handler|event_handler:ms|None
- empty_lock_devices_on_ball_end: single|bool|false
And here.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1617 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGH7XMBKSLWEQO7TSX3C6FTULBORXANCNFSM5HRXO53A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I checked the box for allow edits from maintainers, but I do not know how to edit or revert the changes not wanted. Sorry, very new to github and not a developer. |
Dont worry. Will have a look later |
jabdoa2
approved these changes
Nov 15, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a quick change to enable 8 segment virtual display