Bugfix orphaned handlers on shot groups #1622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks! Good one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug created in 58d3df6 that causes shot groups to continually add event handlers.
The change in 58d3df6 introduces new handlers for the ShotGroup's
self._check_for_completewhen the device is added to a mode, but these handlers are never removed. The next time the mode starts, they are all added again.This PR removes these handlers in the ShotGroup's
self.device_removed_from_mode()method, and adds a test to prevent regression.Also, this PR adds a catch during shutdown. During a catastrophic failure, e.g. a syntax error in an MPF file that prevents startup,
self.eventsis undefined and that subsequent error blocks the stacktrace of the underlying syntax error. This catch allows the machine to gracefully shutdown and display a useful stacktrace.