Post timer_(name)_tick event on restart when already running #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in Timers'
restartbehavior.The
restart()method callsreset()andstart(), but if the Timer is already running then thestartmethod exits immediately. There is a bug here because the start method is meant to post the timer_name_tick event, but the early exit prevents that code path. As a result, callingrestart()on a stopped Timer will post the timer_name_tick event but callingrestart()on a running Timer will not post the event, and it will be another full tick before any listeners know that the timer tick has changed.This PR tweaks the
restart()behavior to only callstart()the timer is not running, and otherwise post the event directly. For safety, an instance elsewhere of callingreset()thenstart()was replaced with a call torestart().Also, a test!