Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplifies attr check related to IMC #1627

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Conversation

atummons
Copy link
Contributor

@atummons atummons commented Jan 7, 2022

Users getattr instead of hasattr to remove one boolean. Sets a default value to false if the attribute doesn't exist.

Users getattr instead of hasattr to remove one boolean
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@avanwinkle avanwinkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@jabdoa2 jabdoa2 merged commit 59c0ba3 into missionpinball:dev Feb 26, 2022
@atummons atummons deleted the fix_imc branch August 31, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants