Syncs up chimes with reel coil pulse #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds conssitency for the will_xx _xxing and _xxed format to the advancement of the score reel. Changed the event handler for chime pulses to be the _advancing event, which triggers at the same time as the coil advance pulse. The only potential break is if someone is queueing custom events off the reel_(name)_advance event as this is now _advanceD (past tense).
|
Kudos, SonarCloud Quality Gate passed!
|
jabdoa2
reviewed
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds conssitency for the will_xx _xxing and _xxed format to the
advancement of the score reel. Changed the event handler for chime
pulses to be the _advancing event, which triggers at the same time as
the coil advance pulse.
The only potential break is if someone is queueing custom events off the
reel_(name)_advance event as this is now _advanceD (past tense).