Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval placeholder args in show update method (from #1702) #1750

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Eval placeholder args in show update method (from #1702) #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mpf/assets/show.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,7 @@ def update(self, **kwargs):
Updates the values of a show while it runs. Currently supports only speed
and manual_advance properties.
"""
updated_values = {k: v for k, v in kwargs.items() if v is not None and v != getattr(self.show_config, k)}
updated_values = {k: v for k, v in kwargs.items() if v is not None}
if updated_values:
self.show_config = self.show_config._replace(**updated_values)

Expand Down
3 changes: 1 addition & 2 deletions mpf/config_players/show_player.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,10 +197,9 @@ def _update(key, instance_dict, show, show_settings, queue, start_time, placehol
del show
del queue
del start_time
del placeholder_args
if key in instance_dict:
instance_dict[key].update(
speed=show_settings.get('speed'),
speed=show_settings['speed'].evaluate(placeholder_args),
manual_advance=show_settings.get('manual_advance')
)

Expand Down
Loading