Segment display replace #1840
Open
Segment display replace #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using replace update method the default flashing, mask and color props are empty or none. This causes the text not to displayed or flashed when it shouldn't be. This update uses the current state's settings for new text if none are set.
|
|
Thanks for the input, have you looked at #1820 to see where your respective changes align/diverge? |
|
@mpcarr the PR @avanwinkle has referenced is from me. I believe my fix should cover your case and even some more. I have the impression that segment displays are not that widely used and it is hard to get test cases validated. Would you mind to test my code changes in your project and report back? If you find issues I am willing (happily with you together) to fix these to get a better segment display support into mpf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1839. The newly added replace feature ([https://github.com//pull/1779](Segment Displays: Stack vs Replace Option).
This update using the current states color, flashing and flash_mask settings for the incoming text if non are specified on the segment_display_player. Without this, the text isn't displayed due the the color being missing and the text is set to flash.
Additionally this update removes the text from the display when the update method is not stack.