-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unsupported emojis should render the shortcode #157
Comments
We're also having this issue. I'm ok with rendering the shortname or maybe add a callback? |
Went the callback way, as picker still requires unsupported emojis to be ignored. Here’s how you would render <Emoji
set={'messenger'}
emoji={'shrug'}
size={24}
fallback={(emoji) => {
return `:${emoji.short_names[0]}:`
}}
/> I hope that’s good enough 😄 |
Woah, that was crazy fast. Thanks heaps! |
ajbeaven
added a commit
to ajbeaven/emoji-mart
that referenced
this issue
Jan 9, 2018
EtienneLem
added a commit
that referenced
this issue
Jan 15, 2018
Emoji fallback shouldn't apply styling #157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've found that 🤷 doesn't seem to render anything when using the messenger set:
Presumably this is because the messenger set doesn't support this emoji? In my opinion, it's better to render something rather than nothing. I'd suggest using the raw shortcode passed in to the emoji.
The text was updated successfully, but these errors were encountered: