Adds Spritesheets for Custom Emojis #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great work @Kennybll, definitely speeds things along... and hopefully this can be merged in short order! 👍 😁 |
|
Great work indeed. Exactly what I had in mind, thanks! 🤘 |
EtienneLem
added a commit
that referenced
this pull request
Mar 15, 2019
+ add missing prop types since #251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for spritesheets as asked in #247. I opted out of using 'position: [row, column]' because the variables sheet_(x|y), size, and sheet(Columns|Rows) are already implemented. The main thing added is spriteUrl to the custom emoji data.