-
Notifications
You must be signed in to change notification settings - Fork 835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve a11y of emoji list #284
Conversation
fix: improve a11y of emoji list
fix: improve a11y of emoji list
OK, I've added an |
@nolanlawson when I visit https://missive.github.io/emoji-mart/ |
Yes, in terms of improving the accessibility of emoji-mart, I didn't make it a full autocomplete pattern where you can press the arrow keys to navigate between results. You have to just use the regions to move around after typing into the search bar. Certainly not a perfect design a11y-wise, but it's at least usable with a keyboard, whereas before it wasn't. Should we open up a separate issue to improve the a11y further? |
It now works with VoiceOver, it is possible to loop through the picker elements and "click" them. It does not work with regular keyboard control (no Voice Over, just arrow keys). This is actually expected, and the parent project [change](missive/emoji-mart#284) also states that: > should I now be able to type, then navigate results via arrow keys? Yes, in terms of improving the accessibility of emoji-mart, I didn't make it a full autocomplete pattern where you can press the arrow keys to navigate between results. You have to just use the regions to move around after typing into the search bar. Certainly not a perfect design a11y-wise, but it's at least usable with a keyboard, whereas before it wasn't.
It now works with VoiceOver, it is possible to loop through the picker elements and "click" them. It does not work with regular keyboard control (no Voice Over, just arrow keys). This is actually expected, and the parent project [change](missive/emoji-mart#284) also states that: > should I now be able to type, then navigate results via arrow keys? Yes, in terms of improving the accessibility of emoji-mart, I didn't make it a full autocomplete pattern where you can press the arrow keys to navigate between results. You have to just use the regions to move around after typing into the search bar. Certainly not a perfect design a11y-wise, but it's at least usable with a keyboard, whereas before it wasn't.
fixes #218
This isn't my ideal implementation, but it broadly fixes the issues in #218. It's a good start. 🙂
<span>
into a<button>
so that it's keyboard-accessible<section>
with anaria-label
corresponding to that section (should probably be a<ul>
, but we can do that later)<section>
with its ownaria-label
, currently defaulting to "List of emoji". This can be tweaked using thei18n
object.Potentially we could also include the shortcodes in the
aria-label
for each button; for now it's just the emoji itself.