Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'defaults' browserslist to emoji-mart package.json #619

Merged

Conversation

AbhayVAshokan
Copy link
Contributor

Fixes #613
Fixes #602
Fixes #582

Added browserslist as defaults to package.json of emoji-mart package. This makes sure that the code is transpiled to support wider range of browsers.

Quoting from parcel:

By default Parcel does not perform any code transpilation. This means that if you write your code using modern language features, that’s what Parcel will output. You can declare your app’s supported browsers using the browserslist field. When this field is declared, Parcel will transpile your code accordingly to ensure compatibility with your supported browsers.

Having a browserslist key in package.json has the additional benefit of specifying which all browsers the current version of the package supports. Keeping it as defaults makes sure it is as per the current standards.

I have tested out the build locally, I can confirm that it transpiles properly in the project that we are working on.

@EtienneLem, please have a look into this issue. We had to resort to the v3 of this package for multiple projects due to this persisting issue.

@ehynds
Copy link

ehynds commented Jun 22, 2022

@EtienneLem Can we can get merged?

@EtienneLem EtienneLem merged commit c083104 into missive:main Jul 13, 2022
@EtienneLem
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants