Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use maxWidth / maxHeight for image Emoji #712

Closed
wants to merge 1 commit into from
Closed

Use maxWidth / maxHeight for image Emoji #712

wants to merge 1 commit into from

Conversation

TranquilMarmot
Copy link
Contributor

@TranquilMarmot TranquilMarmot commented Oct 7, 2022 •
edited
Loading

We noticed that with non-square custom emoji, they would overlap each other.

By using maxWidth / maxHeight here, they will still be the right size but will not expand beyond the size passed in to props.

@EtienneLem
Copy link
Member

Great, thanks! Would need a rebase.

@EtienneLem
Copy link
Member

Merged in 73714b3

@EtienneLem EtienneLem closed this Nov 10, 2022
@realtrev realtrev mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EtienneLem EtienneLem EtienneLem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TranquilMarmot @EtienneLem